Repository navigation
fix(advisory): clean staging directory on SIGINT and SIGTERM during sync - #1663
Open
Nachiket-Roy wants to merge 1 commit into
Open
Nachiket-Roy wants to merge 1 commit into
Nachiket-Roy wants to merge 1 commit into
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
This pull request improves the robustness of the
syncOsvAdvisoriesfunction by ensuring proper cleanup of temporary resources and signal handlers. It also adds comprehensive tests to verify these behaviors.Resource and signal handler management:
osv-sync.tsto register and removeSIGINTandSIGTERMlisteners during the advisory sync process, ensuring that temporary staging directories are cleaned up if the process is interrupted by these signals.Testing enhancements:
osv-sync.test.tsto verify that signal listeners are correctly removed after sync completion or error, and that temporary directories are cleaned up if aSIGINTis received during sync.Closes #1661